Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add metadata_json_deps + rake task" #54

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak added the bug Something isn't working label Aug 26, 2021
@bastelfreak bastelfreak requested a review from ekohl August 26, 2021 09:55
@bastelfreak bastelfreak self-assigned this Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #54 (35b707b) into master (ed10815) will increase coverage by 2.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   25.75%   28.33%   +2.57%     
==========================================
  Files           2        2              
  Lines          66       60       -6     
==========================================
  Hits           17       17              
+ Misses         49       43       -6     
Impacted Files Coverage Δ
lib/voxpupuli/test/rake.rb 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed10815...35b707b. Read the comment docs.

@bastelfreak
Copy link
Member Author

for the record: I still think that this is really helpful in our modules, but with the broken gettext-setup implementation it's not always useable. Instead of figuring out when it breaks and when not it's best to revert it for now.

Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for removal. We have it in our modulesync_config (https://github.com/voxpupuli/modulesync_config/blob/4dfcd16dad09d82fc9bf32858ed6b59529d40044/Rakefile#L3-L7) which can run in bulk. That is also more efficient since you can cache the module versions on the forge which helps a lot (no need to check for stdlib about a 100 times).

@bastelfreak bastelfreak merged commit e041de1 into voxpupuli:master Aug 26, 2021
@bastelfreak bastelfreak deleted the bla branch August 26, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants