Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append check:trailing_whitespace rake task to check and not release_checks #48

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak requested a review from ekohl August 9, 2021 09:09
@bastelfreak bastelfreak self-assigned this Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #48 (58dac77) into master (0a57465) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 58dac77 differs from pull request most recent head 12182fa. Consider uploading reports for the commit 12182fa to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   25.75%   25.75%           
=======================================
  Files           2        2           
  Lines          66       66           
=======================================
  Hits           17       17           
  Misses         49       49           
Impacted Files Coverage Δ
lib/voxpupuli/test/rake.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a57465...12182fa. Read the comment docs.

@bastelfreak bastelfreak added the bug Something isn't working label Aug 9, 2021
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the summary the other way around?

You should also increase the minimum version to 2.16.0 which added the check task.

@bastelfreak bastelfreak changed the title Append check:trailing_whitespace rake task to release_checks and not check Append check:trailing_whitespace rake task to check and not release_checks Aug 9, 2021
@bastelfreak bastelfreak merged commit de36f67 into voxpupuli:master Aug 9, 2021
@bastelfreak bastelfreak deleted the check branch August 9, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants