Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on puppet-lint >= 2.5.0 #45

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

bastelfreak
Copy link
Member

puppet-lint is required for Ruby 3 support.

@bastelfreak bastelfreak self-assigned this Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #45 (5f302ad) into master (1c8c3ca) will not change coverage.
The diff coverage is n/a.

❗ Current head 5f302ad differs from pull request most recent head b97b271. Consider uploading reports for the commit b97b271 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   28.33%   28.33%           
=======================================
  Files           2        2           
  Lines          60       60           
=======================================
  Hits           17       17           
  Misses         43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8c3ca...b97b271. Read the comment docs.

voxpupuli-test.gemspec Outdated Show resolved Hide resolved
puppet-lint is required for Ruby 3 support.
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't hurt to explicitly depend on puppet-lint rather than implicitly.

@bastelfreak bastelfreak merged commit bc3e9fb into voxpupuli:master Jul 27, 2021
@bastelfreak bastelfreak deleted the puppet-lint branch July 27, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants