Disable Style/TrailingCommaInArguments #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the trailing , in
```ruby
it {
is_expected.to contain_concat__fragment('nftables-inet-filter-chain-default_out-rule-dnsudp').with(
target: 'nftables-inet-filter-chain-default_out',
content: %r{^ udp dport 53 accept$},
order: '50-nftables-inet-filter-chain-default_out-rule-dnsudp-b',
)
}
```
throws a warning. This is inconsistent with what is permitted in
puppet.
|
I'm in general 👍 for this, but this would cause a lot of trouble to existing modules because we would need to fix it in ~180 modules. |
|
I assumed this was allow something rather than force someone to change to something? |
ekohl
approved these changes
Dec 8, 2020
traylenator
added a commit
to traylenator/puppet-nftables
that referenced
this pull request
Dec 8, 2020
Can be reverted once voxpupuli/voxpupuli-test#36 is released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the trailing , in
throws a warning. This is inconsistent with what is permitted in
puppet.