Determine correct facter version based on puppet #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code comes from modulesync_config: voxpupuli/modulesync_config@666105a
alexjfisher
approved these changes
Feb 9, 2020
ekohl
reviewed
Feb 10, 2020
| def suggest_facter_version | ||
| require 'bundler' | ||
| Gem::Dependency.new('', ENV['PUPPET_VERSION']).match?('', '5') ? '3.11.0' : '3.14.0' | ||
| c.default_facter_version = if ENV['FACTERDB_FACTS_VERSION'] |
There was a problem hiding this comment.
This can't work. There is no c i this scope. I'll submit a PR to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code comes from modulesync_config:
voxpupuli/modulesync_config@666105a