Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add puppet-lint-file_ensure-check #24

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Add puppet-lint-file_ensure-check #24

merged 1 commit into from
Jul 1, 2020

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak self-assigned this Jul 1, 2020
ekohl
ekohl approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm biased since in the foreman we already use this, but IMHO it is a good check. I think we should ask ourselves how breaking this is: is it a major or a minor version.

@bastelfreak
Copy link
Member Author

probably major, but the next release already will be a major one, so I think it's a good idea to implement the linters now :)

@bastelfreak bastelfreak merged commit 8264316 into voxpupuli:master Jul 1, 2020
@bastelfreak bastelfreak deleted the bla2 branch July 1, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees

@bastelfreak bastelfreak

Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @ekohl