Add github_release alias for travis_release task
#28
Conversation
There was a problem hiding this comment.
👍 the travis is confusing!
Maybe it is more future-proof to rename the existing implementation and add a task with the old name for backward compatibility?
And maybe we can also have a release task that also run github_release for even more future-proof-proofness 😄 ?
|
I also thought more about a generic name. |
|
@ekohl I thought about it, but I wanted to avoid collisions and I wasn't sure which namespace is the best. Do you have a suggestion? |
bastelfreak
force-pushed
the
github_release
branch
from
e7b964e to
c422af1
Compare
bastelfreak
force-pushed
the
github_release
branch
from
c422af1 to
4e165b1
Compare
| @@ -33,6 +33,11 @@ | |||
| g.push! | |||
| end | |||
|
|
|||
| desc 'Release via GitHub Actions (alias for travis_release)' | |||
| task :release do | |||
| Rake::Task['travis_release'].invoke | |||
There was a problem hiding this comment.
I think I'd have preferred the other way around. Rename travis_release to release and add a travis_release for backwards compatibility. Then travis_release should also output a warning that it's deprecated.
There was a problem hiding this comment.
Ah thanks. I see it didn't add a warning. That can still be a good addition.
No description provided.