Rubocop fixes

lib/helpers/deployments.rb

@@ -42,8 +42,8 @@ def deploy_module(module_name)
       result = PuppetWebhook::Mcollective.new('r10k',
                                               'deploy',
                                               {
-                                                  dtimeoute: settings.discovery_timeout,
-                                                  timeout: settings.client_timeout
+                                                dtimeoute: settings.discovery_timeout,
+                                                timeout: settings.client_timeout
                                               },
                                               settings.client_cfg,
                                               module: module_name).run.first

lib/plugins/mcollective.rb

@@ -1,11 +1,12 @@
 require 'mcollective'
 
 class PuppetWebhook
+  # Creates an Mcollective Agent object for running MCO agents
   class Mcollective
     attr_writer :agent, :command
     include MCollective::RPC
 
-    def initialize(agent, command, timeouts = nil, options = nil, nodes = [], **args)
+    def initialize(agent, command, timeouts = nil, options = nil, nodes = [], **args) # rubocop:disable Metrics/ParameterLists
       @agent = agent
       @command = command
       @timeout = timeouts[:timeout] || '120'
@@ -22,7 +23,7 @@ def run
         client.send(@command, @args) do |result|
           result
         end
-      rescue => e
+      rescue StandardError => e
         LOGGER.error("Error: #{e}")
       end
     end

spec/unit/plugins/webhook_mcollective_spec.rb

@@ -8,19 +8,19 @@
     end
     it 'should run correctly' do
       result_data = {
-        :agent => 'puppet',
-        :action => 'disable',
-        :sender => 'example.net',
-        :statuscode => 0,
-        :statusmsg => 'OK',
-        :data => {
-            :status => "Succesfully locked the Puppet agent: Disabled via MCollective by choria=vp.mcollective at 2017-12-25 07:59",
-            :enabled => false
+        agent: 'puppet',
+        action: 'disable',
+        sender: 'example.net',
+        statuscode: 0,
+        statusmsg: 'OK',
+        data: {
+          status: 'Succesfully locked the Puppet agent: Disabled via MCollective by choria=vp.mcollective at 2017-12-25 07:59',
+          enabled: false
         }
       }
 
       allow(PuppetWebhook::Mcollective).to receive(:run).and_return(result_data)
       expect(PuppetWebhook::Mcollective.run).to eq(result_data)
     end
   end
-end
+end