Make filtering on dest addr optional #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `$destination_addresses` was an array with the public ipv6/ipv4 addresses. Those were used as destination address in the firewall rules. People might have dynamic local ips so this won't work/creates a lot of noise due to constant firewall rule updates. As a fix, it was already possible to set `$destination_addresses` to an empty Array (`[]`). But passing this to the `daddr` parameter in ferm::rule created a broken firewall rule. This patch sets the `daddr` parameter to `undef` if `$destination_addresses` is an empty array.
TuningYourCode
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
$destination_addresseswas an array with the publicipv6/ipv4 addresses. Those were used as destination address in the
firewall rules. People might have dynamic local ips so this won't
work/creates a lot of noise due to constant firewall rule updates. As a
fix, it was already possible to set
$destination_addressesto an emptyArray (
[]). But passing this to thedaddrparameter in ferm::rulecreated a broken firewall rule. This patch sets the
daddrparameter toundefif$destination_addressesis an empty array.Pull Request (PR) description
This Pull Request (PR) fixes the following issues