Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppRole Authentication #59

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Conversation

crayfishx
Copy link
Contributor

This PR adds AppRole authentication to the vault_lookup function. I've tried to do this in a similar way to the current implementation of certs (although some of it is a bit convulted) to keep consistency. The lookup will still default to cert auth if nothing changes so it shouldnt pose any kind of backwards compatibility issues..... env vars can be overridden to enable approle auth.....

export VAULT_AUTH_METHOD=approle
export VAULT_ROLE_ID=XXXXX-XXXX-XXX-XX-XXXXXXXXXX
export VAULT_SECRET_ID=YYYYY-YYYY-YYY-YY-YYYYYYYYYYY

I simplified some of the function calls to avoid duplication of the token request code after adding this in.

@bastelfreak bastelfreak changed the title Added AppRole Authentication Add AppRole Authentication Sep 27, 2022
@bastelfreak bastelfreak added the enhancement New feature or request label Sep 27, 2022
@bastelfreak bastelfreak merged commit d00dda5 into voxpupuli:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants