Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds AppRole authentication to the vault_lookup function. I've tried to do this in a similar way to the current implementation of certs (although some of it is a bit convulted) to keep consistency. The lookup will still default to cert auth if nothing changes so it shouldnt pose any kind of backwards compatibility issues..... env vars can be overridden to enable approle auth.....
I simplified some of the function calls to avoid duplication of the token request code after adding this in.