-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modulesync 5.4.0 #47
Modulesync 5.4.0 #47
Conversation
I'm not sure if/how the acceptance tests ever worked |
I had that same question in #33 (comment). It also looks like #91 is still open for this module. |
For what it's worth, I don't think this module is compatible with our standard CI. It uses a custom nodeset: in 336c0b7 it was explicitly pinned to this setfile. I don't have a good answer to this. It's a good question for advanced uses. For now I'd recommend not managing the GitHub action until we come up with a good solution. |
bcafaf0
to
6d4dd37
Compare
I'm hoping for a release of this module soon. Can we maybe restart this PR from a fresh branch based of Modulesync 5.4.0? |
6d4dd37
to
4c656c4
Compare
@natemccurdy if you like you can start a fresh modulesync, we've some docs about it at: https://github.com/voxpupuli/modulesync_config/#modulesync-configs If you have quesitons feel free to ask in #voxpupuli on IRC or slack. |
@smortex FYI, this module was updated to modulesync |
Great! Let's close this then! Thank you |
Pull Request (PR) description
The primary goal is to check CI status…
This Pull Request (PR) fixes the following issues