Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulesync 5.4.0 #47

Closed
wants to merge 12 commits into from
Closed

Modulesync 5.4.0 #47

wants to merge 12 commits into from

Conversation

smortex
Copy link
Member

@smortex smortex commented Dec 9, 2021

Pull Request (PR) description

The primary goal is to check CI status…

This Pull Request (PR) fixes the following issues

@bastelfreak
Copy link
Member

I'm not sure if/how the acceptance tests ever worked

@ekohl
Copy link
Member

ekohl commented Feb 8, 2022

I had that same question in #33 (comment). It also looks like #91 is still open for this module.

@ekohl
Copy link
Member

ekohl commented Feb 9, 2022

For what it's worth, I don't think this module is compatible with our standard CI. It uses a custom nodeset: in 336c0b7 it was explicitly pinned to this setfile.

I don't have a good answer to this. It's a good question for advanced uses. For now I'd recommend not managing the GitHub action until we come up with a good solution.

@natemccurdy natemccurdy changed the title Modulesync 5.1.0 Modulesync 5.4.0 Feb 24, 2023
@natemccurdy
Copy link
Contributor

natemccurdy commented Feb 24, 2023

I'm hoping for a release of this module soon. Can we maybe restart this PR from a fresh branch based of Modulesync 5.4.0?

@bastelfreak
Copy link
Member

@natemccurdy if you like you can start a fresh modulesync, we've some docs about it at: https://github.com/voxpupuli/modulesync_config/#modulesync-configs

If you have quesitons feel free to ask in #voxpupuli on IRC or slack.

@natemccurdy
Copy link
Contributor

@smortex FYI, this module was updated to modulesync 5.5.0 in voxpupuli/plumbing#80

@smortex
Copy link
Member Author

smortex commented May 5, 2023

Great! Let's close this then!

Thank you

@smortex smortex closed this May 5, 2023
@smortex smortex deleted the modulesync branch May 5, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants