Run acceptance tests in travis #11
Conversation
tvpartytonight
force-pushed
the
run_acceptance_in_travis
branch
2 times, most recently
from
4c2ee66 to
afa7f55
Compare
|
I think we'll have to do something to make this work, because I think the Vox settings will just overwrite this when modulesync happens... @bastelfreak am I right? |
| @@ -22,6 +23,9 @@ matrix: | |||
| - rvm: 2.4.4 | |||
| bundler_args: --without system_tests development release | |||
| env: PUPPET_VERSION="~> 5.0" CHECK=build DEPLOY_TO_FORGE=yes | |||
| - rvm: 2.5.1 | |||
| bundler_args: --without development release | |||
| env: CHECK=acceptance | |||
There was a problem hiding this comment.
all the changes in this file need to go in the sync yaml
There was a problem hiding this comment.
I manually just synced the added cell without using pdk update...is that ok?
There was a problem hiding this comment.
We don't yet use pdk, we currently use https://github.com/voxpupuli/modulesync_config/ as template for our modules.
This commit adds configuration to the travis yml to run `rake acceptance`.
Before this change, there was some tomfoolery around moving the certs onto the puppetserver, which result in strange and inconsistent behavior when the certificate file locations were modified while the puppetserver was running. This change separates out those certs to a specific image that both the vault and puppetserver images use, making the initialization of puppetserver cleaner without having to restart it.
This change allows the protocol to be http only.
tvpartytonight
force-pushed
the
run_acceptance_in_travis
branch
from
afa7f55 to
7cab293
Compare
|
@petems I don't think there are any problems with modulesync; there's an obtuse error when mocking out the |
|
@tvpartytonight Sorry should have clarified, not a test error, but the The VoxPop modulesync will overwrite the Travis config AFAIK (https://github.com/voxpupuli/modulesync_config) But I'm super behind the times so might not be the case anymore 🤷♂️ |
|
It looks like maybe the Travis file is generated from this ERB template: https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.travis.yml.erb. So I wonder if it would overwrite the |
| @@ -0,0 +1,67 @@ | |||
| FROM alpine:3.8 | |||
There was a problem hiding this comment.
We normally try to generate the dokerfiles on the fly by using https://github.com/puppetlabs/beaker-hostgenerator, but this one looks pretty specific, so a custom file is fine.
|
Hey people, thanks for enabling the acceptance tests. I will merge this now and afterwards have a look at the modulesync integration. |
This PR adds configuration to the travis yml to run
rake acceptance.