Add Environmental Lookup option #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petems
force-pushed
the
add_environmental_lookup
branch
3 times, most recently
from
3d0b43f to
006e960
Compare
alexjfisher
reviewed
Nov 28, 2018
petems
force-pushed
the
add_environmental_lookup
branch
2 times, most recently
from
815ef62 to
95592a0
Compare
alexjfisher
reviewed
Nov 28, 2018
* We don’t always know what the Vault address will Be * Pulling from ENV value makes sense for this case * Adds spec, and updates existing specs to check for the vault address given
petems
force-pushed
the
add_environmental_lookup
branch
from
95592a0 to
0131454
Compare
alexjfisher
approved these changes
Nov 28, 2018
|
Got the thumbs up! Gonna merge 👍 |
|
Thanks @petems ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VAULT_ADDR read from environment
Closes #8