Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the Unattended-Upgrade::MailReport setting to unattended-upgrades.erb #181

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

kenyon
Copy link
Member

@kenyon kenyon commented Sep 29, 2020

Pull Request (PR) description

Add the ability to configure the Unattended-Upgrade::MailReport setting. See https://github.com/mvo5/unattended-upgrades/blob/master/README.md for setting reference.

@ghoneycutt ghoneycutt merged commit 0299dc2 into voxpupuli:master Sep 29, 2020
@@ -112,7 +112,8 @@ altering some of the default settings.
xenial, bionic and default), `false` for Debian (wheezy and default)):
Use the legacy `Unattended-Upgrade::Allowed-Origins` setting or the modern `Unattended-Upgrade::Origins-Pattern`.
* `mail`: A hash to configure email behaviour with two possible keys:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‘Two possible keys’?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, there are now three possible keys. #183 fixes this.

@alexjfisher
Copy link
Member

alexjfisher commented Sep 29, 2020

@ghoneycutt Thanks for reviewing, but could you be a bit less trigger happy with the merge button? 15 minutes doesn’t give a lot of opportunity for anyone else to take a look at a PR.

Edit - actually closer to 30 minutes (I think github was confusing me with some rounding)

@ghoneycutt
Copy link
Member

@alexjfisher apologies, i saw code that looked good with sufficient tests, so I merged :)

@bastelfreak bastelfreak added the enhancement New feature or request label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants