-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove spurious ':' from refresh_pattern template #87
Conversation
03fdd5d
to
4001565
Compare
in doubt about the : which is used in the template, that should not be fixed, only few refresh_patterns use it, gonna change that too... after some testing... |
When using a regexp (when case_sensitive is set to false) the -i should be placed BEFORE the $name and not after Also fixed that no space was used between the max and options field, added rspec for options Removed default : which was used, this is not default, changed README so ^ftp: has it mentioned
4001565
to
4cdfe85
Compare
remove the default use of : after the title, this is not default, see examples: |
seems I didn't check all the PR's, this is in part: #65 |
To be clear someone doing. squid::refresh_pattern{'ftp':
min => 20,
max => 30,
percent 100,
} were getting
and now the will get
backwards incompatible but the old behaviour was wrong. |
Correct, the old behaviour was wrong, see also #65 which also addresses this, but fails in Travis... For you sample, the person would have to use:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all make sense. The : should not be there.
When using a regexp (when case_sensitive is set to false)
the -i should be placed BEFORE the $name and not after
Also fixed that no space was used between the max and
options field, added rspec for options