Snmp access #79
Merged
Snmp access #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
Jan 21, 2018
README.md
Outdated
| @@ -175,6 +175,36 @@ Adds a squid.conf line | |||
| http_access allow our_networks hosts | |||
| ``` | |||
|
|
|||
| ### Defined Type squid::snmp\_access | |||
| Defines [snmp_access entries](snmp://www.squid-cache.org/Doc/config/snmp_access/) for a squid server. | |||
There was a problem hiding this comment.
That's a funny looking URL :)
alexjfisher
reviewed
Jan 21, 2018
README.md
Outdated
| Adds a squid.conf line | ||
|
|
||
| ``` | ||
| # snmp_access fragment for out_monitoring hosts |
alexjfisher
reviewed
Jan 21, 2018
| @@ -17,6 +17,7 @@ | |||
| Optional[String] $coredump_dir = $squid::params::coredump_dir, | |||
| Optional[Hash] $extra_config_sections = {}, | |||
| Optional[Hash] $http_access = $squid::params::http_access, | |||
| Optional[Hash] $snmp_access = $squid::params::snmp_access, | |||
There was a problem hiding this comment.
Looks like you've forgotten to set a default in params.pp
There was a problem hiding this comment.
and that's why the tests are failing.
alexjfisher
requested changes
Jan 21, 2018
|
params.pp has now been created. |
|
@SourceDoctor thanks. This snmp one is one I had been intending to add for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access Rules for snmp Requests (equal to http_access)