Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added debian 9 param defaults #60

Merged
merged 2 commits into from
Sep 14, 2017
Merged

added debian 9 param defaults #60

merged 2 commits into from
Sep 14, 2017

Conversation

ssanden
Copy link
Contributor

@ssanden ssanden commented Sep 6, 2017

debian 9 defaults

debian 9 defaults
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't verified this on a Debian 9 machine but it looks correct.

@traylenator
Copy link
Contributor

Hi @ekohl
Can you update the metadata.yaml file also for the new platform - thanks.

@traylenator traylenator added enhancement New feature or request needs-work not ready to merge just yet labels Sep 12, 2017
@traylenator
Copy link
Contributor

traylenator commented Sep 12, 2017

Please remove the needs-work tag when you would like me to take a look again.

@ekohl
Copy link
Member

ekohl commented Sep 12, 2017

Hi @ekohl
Can you update the metadata.yaml file also for the new platform - thanks.

I think you mean @traylenator

Please remove the needs-work tag when you would like me to take a look again.

I can do that since I'm a member but @ssanden can't.

@traylenator
Copy link
Contributor

I meant @ssanden

@ssanden
Copy link
Contributor Author

ssanden commented Sep 13, 2017

Can you update the metadata.yaml file also for the new platform - thanks.

done

@wyardley wyardley removed the needs-work not ready to merge just yet label Sep 14, 2017
@wyardley
Copy link
Contributor

I'll merge this.

I was going to look into adding a Debian 9 box in modulesync so we could run acceptance tests, but doesn't seem to be one yet at:
https://vagrantcloud.com/puppetlabs
Couldn't get the Docker one to work on a quick try, but will give it another try later.

@wyardley wyardley merged commit 76bb620 into voxpupuli:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants