Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow puppetlabs-concat 9.x #182

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Allow puppetlabs-concat 9.x #182

merged 1 commit into from
Jul 13, 2023

Conversation

smortex
Copy link
Member

@smortex smortex commented Jul 12, 2023

No description provided.

@zilchms
Copy link
Contributor

zilchms commented Jul 13, 2023

isnt that change already contained in #183 too?

zilchms
zilchms approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@zilchms zilchms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway, still reasonable :)

@smortex
Copy link
Member Author

smortex commented Jul 13, 2023

isnt that change already contained in #183 too?

Yep, when merging 183, github will also mark this PR as merged because its commit will be in main 😉. This help to work on related changes (test them in CI the one above the other) with still readable changelog.

Feel free to test it :-)

@bastelfreak bastelfreak merged commit 757afdd into master Jul 13, 2023
@bastelfreak bastelfreak deleted the concat branch July 13, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilchms zilchms zilchms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smortex @zilchms @bastelfreak