Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.0 #173

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Release 4.0.0 #173

merged 2 commits into from
Dec 19, 2022

Conversation

bk-lg
Copy link
Contributor

@bk-lg bk-lg commented Dec 19, 2022

Pull Request (PR) description

In refrerence to issue #172 I updated metadata.json and the corresponding documentation for a 4.0.0 release.
I hope that a new major release os correct in your interpretation of semantic versioning.

This Pull Request (PR) fixes the following issues

Fixes #172

@bk-lg
Copy link
Contributor Author

bk-lg commented Dec 19, 2022

@smortex The pipeline succeded but there are warnings about centos 8 with a timeout for the systemd service. I have at the moment no access to a centos vm for further investigation. Will this block a new release?

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The warning are due to pending tests (tests we know fail) so can be ignored.

I would like to have another approval form somebody at voxpupuli before merging and releasing a new version, thanks!

@smortex smortex changed the title Raise version to 4.0.0 for supporting Puppet7 and dropping support for Puppet 5 Release 4.0.0 Dec 19, 2022
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't #172 be in the changelog?

CHANGELOG.md Show resolved Hide resolved
@smortex
Copy link
Member

smortex commented Dec 19, 2022

Shouldn't #172 be in the changelog?

I think only PR appear in the changelog and as noted in your other command, #164 includes it.

Let me merge and release this. Thanks @bk-lg !

@smortex smortex merged commit db45dc2 into voxpupuli:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puppet 7 support
3 participants