Remove default empty string parameters #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think I read accept' tests for 8 are currently broken somewhere.... |
|
After After #170 |
smortex
approved these changes
Mar 23, 2022
| @@ -49,7 +49,7 @@ | |||
| it { is_expected.to contain_concat_fragment('squid_header').without_content(%r{^err_page_stylesheet}) } | |||
| end | |||
|
|
|||
| context 'with all parameters set' do | |||
| context 'with all parameters set' do # rubocop:todo RSpec/MultipleMemoizedHelpers | |||
There was a problem hiding this comment.
I got hit by this a lot… Maybe we should consider increase the limit, or disable the test completely?
There was a problem hiding this comment.
Yes.
I've tried re-arranging things to not get this elsewhere but don't quite understand how to avoid it.
For the defined types and parameters
* For `squid::cache_dir` and the parameter `options` the default is now `undef` rather than `''`
* For `squid::snmp_port` and the parameter `options` the default is now `undef` rather than `''`
* For `squid::refresh_pattern` and the parameter `options` the default is now `undef` rather than `''`
* For `squid::http_port` and the parameter `options` the default is now `undef` rather than `''`
* For `squid::http_ports` and the parameter `options` the default is now `undef` rather than `''`
This is backwards compatible for all cases except when `options` has
been explicitly set to `''` but I feel that is a non-case.
e.g.
```puppet
squid::http_port{80:
options => '',
```
would fail.
Resolves the linter problem params_empty_string_assignment.
Disable RSpec/MultipleMemoizedHelpers with rubocop:todo as I am unsure what to do.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
For the defined types and parameters
squid::cache_dirand the parameteroptionsthe default is nowundefrather than''squid::snmp_portand the parameteroptionsthe default is nowundefrather than''squid::refresh_patternand the parameteroptionsthe default is nowundefrather than''squid::http_portand the parameteroptionsthe default is nowundefrather than''squid::http_portsand the parameteroptionsthe default is nowundefrather than''This is backwards compatible for all cases except when
optionshasbeen explicitly set to
''but I feel that is a non-case?e.g.
squid::http_port{80: options => '',would fail.
Resolves the linter issues for
params_empty_string_assignment.Extra commits include: