Allow multiple logformat directives in squid.conf #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
reviewed
Mar 12, 2022
templates/squid.conf.header.erb
Outdated
Comment on lines
20
to
24
| <% if @logformat -%> | ||
| <% if @logformat.is_a?(Array) %> | ||
| <% @logformat.each do |logformat_line| -%> | ||
| logformat <%= logformat_line %> | ||
| <% end -%> | ||
| <% else -%> | ||
| logformat <%= @logformat %> | ||
| <% end -%> |
There was a problem hiding this comment.
Maybe it's worth avoiding the duplication, something like:
<% if @logformat -%>
<%- [@logformat].flatten.each do |logformat| -%>
logformat <%= logformat %>
<%- end -%>
<% end -%>There was a problem hiding this comment.
Never saw that format before, sgtm, pushed up.
|
The error: is from squid however. It seems squid as version 4.5. just fails if IPv6 is not available. squid-4.15-3 on 8 was built on the 15th feb so is new. Trying to reproduce outside. |
|
After #170 |
traylenator
reviewed
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Similar to #151, this allows the
logformatparameter to be a String (same as today) or an Array[String], to provide multiplelogformatdirectives to squid.This Pull Request (PR) fixes the following issues
n/a