Override service restart command #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
requested changes
May 14, 2019
ekohl
approved these changes
May 15, 2019
There was a problem hiding this comment.
@alexjfisher looks like your comments were addressed. Mind having another look?
alexjfisher
approved these changes
May 16, 2019
alexjfisher
force-pushed
the
override_service_restart
branch
from
4681fee to
84824ca
Compare
|
Thanks! |
|
Thank you for accepting my PR and maintaining the module 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow the override of service restart default command (https://puppet.com/docs/puppet/5.4/types/service.html#service-attribute-restart) so a soft reload of squid service can be performed. I.E.: Using
systemctl reload-or-restartThis Pull Request (PR) fixes the following issues