Control package status and version #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dan33l
requested changes
May 10, 2019
There was a problem hiding this comment.
@Wiston999 thank you for the PR.
I added son inline comments.
manifests/install.pp
Outdated
| @@ -3,7 +3,7 @@ | |||
| class squid::install { | |||
|
|
|||
| package{$::squid::package_name: | |||
| ensure => present, | |||
| ensure => $::squid::package_ensure, | |||
There was a problem hiding this comment.
Leading colons are not required anymore now.
manifests/init.pp
Outdated
| @@ -10,6 +10,7 @@ | |||
| String $ensure_service = $squid::params::ensure_service, | |||
| Pattern[/\d+ KB/] $maximum_object_size_in_memory = $squid::params::maximum_object_size_in_memory, | |||
| String $package_name = $squid::params::package_name, | |||
| String $package_ensure = $squid::params::package_ensure, | |||
There was a problem hiding this comment.
more accurate Variant[Enum['present','latest'], Pattern[/^\d.*/]]
There was a problem hiding this comment.
I've created a custom type to cover all enum cases (present, latest, absent and purged) and also the Pattern case.
manifests/params.pp
Outdated
| @@ -38,6 +38,7 @@ | |||
| $logformat = undef | |||
| $error_directory = undef | |||
| $err_page_stylesheet = undef | |||
| $package_ensure = present | |||
|
Hi @Wiston999, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Parametrize package ensure value. This lets one install an specific version of the squid package. It also lets absentize or purge the package.
This Pull Request (PR) fixes the following issues