This commit puts a defined in cache_dir.pp #115
Closed
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Dec 28, 2018
manifests/cache_dir.pp
Outdated
| group => $::squid::daemon_group, | ||
| mode => '0750', | ||
| require => Package[$::squid::package_name], | ||
| unless defined(File[$path]) { |
There was a problem hiding this comment.
Should we prefer ensure_resource here?
|
Not the biggest fan of ensure_resource. Found it not working sometimes (when the parameters do not match) it gives me errors. But will change it to ensure_resource. |
Making it possible to create your own cache_dir outside of the Squid module. Fixing issue voxpupuli#108.
|
In #116 an explicit parameter for this was added. I prefer this and think this PR can be closed now. If you disagree, it at least needs the conflict to be resolved :) |
|
Even better implementation, closing this one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it possible to create your own cache_dir
outside of the Squid module. Fixing issue #108.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues