Add a Squid::Size type #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekohl can you take a look at the rubocop errors? |
This type correctly checks the type for sizes. It now allows specifying the maximum_object_size_in_memory in MBs rather than KBs. For correctness we now also check for the full string which means we no longer allow -1 KB or 1 KBB.
|
That was a legitimate mistake where I copied an example but didn't modify the result, fixed. |
|
Restarted failed test.... |
|
💚 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type correctly checks the type for sizes. It now allows specifying the maximum_object_size_in_memory in MBs rather than KBs. For correctness we now also check for the full string which means we no longer allow -1 KB or 1 KBB.