Allow redirecting of settings into custom contexts #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new resource parameter that allows redirection of settings into
contexts other than system/local. In prarticular this allows to
customize (and even create) apps with context =>
"apps/<app>/{default,local}". Incidentally this centralises redundant
occurences of system/local as the parameter default.
|
Phew. Sorry to keep repushing changed commits multiple times but the test suite kinda got to me. It seems to be sorted now. |
|
@crayfishx could you have a look please? |
|
Thanks for the PR @michaelweiser! |
alexjfisher
reviewed
Apr 3, 2019
| @@ -14,6 +14,10 @@ class << self | |||
| def self.file_path | |||
| raise Puppet::Error, 'file_path must be set with splunk_config type before provider can be used' if @file_path.nil? | |||
| raise Puppet::Error, 'Child provider class does not support a file_name method' unless respond_to?(:file_name) | |||
| File.join(@file_path, file_name) | |||
| @file_path | |||
There was a problem hiding this comment.
This breaks instances (as the parent provider instances method no longer uses the correct path). In turn this breaks all settings related to purging unmanaged resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new resource parameter that allows redirection of settings into
contexts other than system/local. In prarticular this allows to
customize (and even create) apps with context =>
"apps//{default,local}". Incidentally this centralises redundant
occurences of system/local as the parameter default.