Added proxy support for provider, and added spec test #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| exec { 'system-rvm-get': | ||
| path => '/usr/local/rvm/bin:/usr/bin:/usr/sbin:/bin', | ||
| command => "rvm get ${version}", | ||
| environment => [ "http_proxy=${proxy_url}" , "https_proxy=${proxy_url}" ], |
There was a problem hiding this comment.
in order to avoid the duplication (here and in other code blocks) you could do
environment => $proxy_url ? { undef => undef, default => [ "http_proxy=${proxy_url}" , "https_proxy=${proxy_url}" ]},
|
thanks, added a comment there to avoid duplication It'd be good to add the proxy_url to |
|
Nice, I'll push a new commit tonight with the change you suggested. |
Rewrote parts to avoid duplication, moved proxy_url to params Avoid duplication
|
Should be good to go. |
|
I had to fix this in 944370, http_proxy was added all the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For people who use the module behind a proxy.