Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Windows support #176

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Drop Windows support #176

merged 1 commit into from
Jan 28, 2022

Conversation

bastelfreak
Copy link
Member

The gnupg module doesn't support windows. Also we cannot run tests on
windows.. This is cherry-picked from #164

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

The gnupg module doesn't support windows. Also we cannot run tests on
windows.
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most, if not all of those OSes are EOL anyway.

@ekohl ekohl merged commit 748c7a1 into voxpupuli:master Jan 28, 2022
@ekohl
Copy link
Member

ekohl commented Jan 28, 2022

Oh, I was so trigger happy but:

$ rg -i windows
manifests/system_user.pp
6:  if $facts['os']['family'] == 'Windows' {
7:    fail('rvm::system_user is not supported on Windows')

manifests/params.pp
4:    'Windows' => false,

spec/defines/system_user_spec.rb
13:      if os_facts[:osfamily] == 'windows'
14:        it { is_expected.to compile.and_raise_error(%r{rvm::system_user is not supported on Windows}) }

Will you clean this up later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants