Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support environment isolation by removing lambdas from title patterns #163

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

joshperry
Copy link

@joshperry joshperry commented Sep 17, 2020

See #162

This seems to result in a noop in our environment. Going to do a little more testing but thought I'd start the discussion.

@HerveMARTIN
Copy link

We're waiting for this PR too...

@saz
Copy link

saz commented Jan 27, 2022

This PR duplicates #143 but looks cleaner. I'd prefer this one.

@vox-pupuli-tasks
Copy link

Dear @joshperry, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@ekohl ekohl force-pushed the environment_isolation branch from 0fbf2c3 to 7f697ee Compare July 6, 2022 11:23
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to rebase your branch to resolve the merge conflict. Once CI passes I'll merge this because it's a good change.

@ekohl ekohl merged commit 48d3c42 into voxpupuli:master Jul 6, 2022
@ekohl ekohl linked an issue Jul 6, 2022 that may be closed by this pull request
@ekohl ekohl added the bug Something isn't working label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Environment Isolation
4 participants