Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop Autofixes #153

Merged
merged 43 commits into from
Feb 9, 2020
Merged

Rubocop Autofixes #153

merged 43 commits into from
Feb 9, 2020

Conversation

alexjfisher
Copy link
Member

This PR is everything rubocop can 'autofix', split into separate commits per cop fixed.

Copy link
Member

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash commits, plz :)

@alexjfisher
Copy link
Member Author

Squashing would entirely defeat the purpose of me splitting out the fixes in the first place. Rubocop can sometimes incorrectly fix stuff and having everything in one enormous commit makes it very difficult to see where it went wrong.

@alexjfisher alexjfisher merged commit 7708708 into voxpupuli:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants