Remove rvm::gpg class
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, I was just going to fix the lint warning, but saw that since
`$package` isn't actually being used, this could be simplified to
```puppet
class rvm::gpg {
include gnupg
}
```
Then I went to see where `rvm::gpg` was actually included, as surely it
could just `include gnupg` itself directly.
Answer: nowhere. Since dfd306e
alexjfisher
force-pushed
the
remove_unused_class
branch
from
30870ea to
dae5ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, I was just going to fix the lint warning, but saw that since
$packageisn't actually being used, this could be simplified toThen I went to see where
rvm::gpgwas actually included, as surely itcould just
include gnupgitself directly.Answer: nowhere. Since dfd306e