Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various fixes #457

Closed
wants to merge 1 commit into from
Closed

Conversation

jwbraucher
Copy link

Pull Request (PR) description

This PR fixes a few things I encountered on my project setting up Rundeck 3.3 with this module:

  • adds support for the new Rundeck server web context parameter (for Rundeck versions 3.3 and above)
  • adds a parameter called "server_address" to configure the listen address of the rundeck service (e.g. 127.0.0.1)
  • adds documentation for the auth_config parameter to the README
  • enables create_resources for rundeck plugins
  • fixes a few parameters in the resource_source defined type
    • endpoint parameter is optional and cannot be present if no value was supplied
    • assume role arn parameter is optional and cannot be present if no value was supplied
    • pageresults is required, so must have a default value if no value was supplied
  • adds support for the "notBy" syntax in Rundeck acl policies
    (https://docs.rundeck.com/docs/manual/document-format-reference/aclpolicy-v10.html#notby)

@@ -122,6 +122,16 @@ The installation directory for Rundeck.
##### `server_web_context`

Web context path to use, such as "/rundeck". `http://host.domain:port/server_web_context`
( Use this for Rundeck versions < 3.3 )

##### `server_web_context33`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it will be better to add optional compatibility param which accepts a version (can be SemVer type) and defaults undef . Then do condition when using server_web_context. This will avoid confusion with 2 different params which have same purpose. Eventually old versions will be deprecated and preserving same param will avoid breaking change.

@Joris29 Joris29 mentioned this pull request Nov 28, 2023
@kenyon kenyon closed this in #520 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants