add custom options parameter to instance #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @trefzer, thanks for the PR! Can we get some basic unit tests for this change? |
trefzer
force-pushed
the
fix_add_custom_options
branch
from
0748139 to
a04998d
Compare
|
Dear @trefzer, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
trefzer
force-pushed
the
fix_add_custom_options
branch
from
a04998d to
e34b0e2
Compare
trefzer
force-pushed
the
fix_add_custom_options
branch
2 times, most recently
from
4365b12 to
02e2b4e
Compare
trefzer
force-pushed
the
fix_add_custom_options
branch
from
02e2b4e to
f5f2c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This is just to add custom options not available as parameters.