Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-venv installation #579

Merged

Conversation

crazymind1337
Copy link
Member

Pull Request (PR) description

If you use python::pyvenv you require the package python-venv (name differs on OSes). This has been missing.

@crazymind1337 crazymind1337 marked this pull request as ready for review November 16, 2020 09:56
@crazymind1337 crazymind1337 force-pushed the fix/python-venv/installation branch 4 times, most recently from 68437c1 to 6d792e4 Compare November 19, 2020 11:21
@bastelfreak
Copy link
Member

@crazymind1337 can you please rebase against our latest master branch?

@crazymind1337 crazymind1337 force-pushed the fix/python-venv/installation branch from 6d792e4 to e915738 Compare December 4, 2020 06:26
@crazymind1337
Copy link
Member Author

@crazymind1337 can you please rebase against our latest master branch?

Done.

@bastelfreak
Copy link
Member

can you take a look at the failing tests? They are passing on master

@crazymind1337
Copy link
Member Author

Oh yes. Will be done next week.

@crazymind1337 crazymind1337 force-pushed the fix/python-venv/installation branch 2 times, most recently from 23a0915 to f039759 Compare December 14, 2020 10:14
@crazymind1337 crazymind1337 added bug Something isn't working and removed tests-fail labels Dec 14, 2020
@crazymind1337 crazymind1337 self-assigned this Dec 14, 2020
@crazymind1337 crazymind1337 force-pushed the fix/python-venv/installation branch from f039759 to 342788a Compare December 15, 2020 10:20
@crazymind1337 crazymind1337 marked this pull request as draft December 15, 2020 10:56
@crazymind1337 crazymind1337 force-pushed the fix/python-venv/installation branch 2 times, most recently from ed824cf to ac20805 Compare December 15, 2020 11:27
@crazymind1337 crazymind1337 force-pushed the fix/python-venv/installation branch 9 times, most recently from 436a8f6 to 8437281 Compare March 1, 2022 16:30
@crazymind1337 crazymind1337 force-pushed the fix/python-venv/installation branch from 8437281 to 4cf8bee Compare March 1, 2022 16:33
@crazymind1337 crazymind1337 marked this pull request as ready for review March 1, 2022 16:43
@crazymind1337
Copy link
Member Author

Looks like I forgot something :D

Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I don't see any backwards-incompatible changes, but I'm also not a python expert. Can you verify that this won't break existing installations?

@crazymind1337
Copy link
Member Author

It would break it so far, if you already have defined a Package[python3-venv] resource, you would run into a duplicate resource. But this is what the fix is for.

@bastelfreak bastelfreak merged commit 96b887f into voxpupuli:master Mar 8, 2022
@crazymind1337 crazymind1337 deleted the fix/python-venv/installation branch June 18, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants