-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python-venv installation #579
Add python-venv installation #579
Conversation
68437c1
to
6d792e4
Compare
@crazymind1337 can you please rebase against our latest master branch? |
6d792e4
to
e915738
Compare
Done. |
can you take a look at the failing tests? They are passing on master |
Oh yes. Will be done next week. |
23a0915
to
f039759
Compare
f039759
to
342788a
Compare
ed824cf
to
ac20805
Compare
436a8f6
to
8437281
Compare
8437281
to
4cf8bee
Compare
Looks like I forgot something :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. I don't see any backwards-incompatible changes, but I'm also not a python expert. Can you verify that this won't break existing installations?
It would break it so far, if you already have defined a |
Pull Request (PR) description
If you use
python::pyvenv
you require the packagepython-venv
(name differs on OSes). This has been missing.