Fix $filename and $mode types in python::dotfile #446
Conversation
bastelfreak
changed the title
|
Hi @gdubicki, thanks for pulling this out of the other PR. Can you please add a simple unit test to https://github.com/voxpupuli/puppet-python/tree/master/spec/defines that ensures that this now compiles? |
gdubicki
force-pushed
the
fix_python_dotfile
branch
from
d444fc1 to
5dd598e
Compare
gdubicki
changed the title
|
Ready to review, @bastelfreak . |
erroneously changed in a990c0b and add tests to ensure this kind of breakage will not repeat
gdubicki
force-pushed
the
fix_python_dotfile
branch
from
024a8b1 to
2bfe404
Compare
|
Can you please trigger a rebuild in Travis, @danquack @bastelfreak ? I think it failed randomly. |
|
It's failing on building image with Debian 9 and Puppet 6, long before testing my code. I propose to comment out this single setup from the matrix and re-enable it in a few days after it starts to work again (?) or fix it/keep it disabled if it wont (outside of this issue, of course). |
as it fails long before running any code test
|
Please don't comment those tests. They're temporary issues at Travis but still something we want to keep in. If it happens too often we should talk to Travis CI support about it. |
|
This broken test is blocking my PR from being merged. And this PR is fixing completely broken dotfile resource. So I suggest we keep my commenting out that test and you can create an issue to fix it and create PR in it to re-enable the test when its fixed, @ekohl. |
|
It was just an intermittent failure. It was likely that a restart of that particular job would have passed. That's why I strongly feel this PR shouldn't modify it. |
This reverts commit bba65fe.
|
Thanks @gdubicki ! |
|
@bastelfreak - I believe this PR fixed #447, so that issue can probably be closed. |
erroneously changed in a990c0b