This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Modulesync 0.19.3 and more #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby 2.1.9 had to be removed because of beaker gem which requires ruby >= 2.2.5
bastelfreak
reviewed
Jan 20, 2017
|
|
||
| # Offense count: 2 | ||
| # Configuration parameters: AssignmentOnly. | ||
| RSpec/InstanceVariable: |
There was a problem hiding this comment.
this whole block will be overwritten by the next modulesync
There was a problem hiding this comment.
maybe disable the cops inside of the spec file?
There was a problem hiding this comment.
there is more overriden next modulesync. all in f711d50
if you know a better way just fix it yourself. :-)
vinzent
added
bug
|
thanks \o/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems tests are failing since 1 year.
Unfortunatly I needed to skip some rspec tests. they work on my computer but not on travis. no idea what cold be wrong. someone with more ruby/augeas knowledge needs to have a look. I opend issue #41
Closes #39