Remove the $listen parameter #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter was used to adjust code directly in the puppetboard checked-out files but the change has been broken by a [commit] in the upstream project about 8 years ago. This was not covered by unit tests so no need of tuning here. Removing this should not harm users, but it still change the interface of the module. [commit]: voxpupuli/puppetboard@cb64b73
smortex
commented
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This parameter was used to adjust code directly in the puppetboard
checked-out files but the change has been broken by a commit in the
upstream project about 8 years ago.
This was not covered by unit tests so no need of tuning here.
Removing this should not harm users, but it still canhge the interface
of the module.
This Pull Request (PR) fixes the following issues
n/a but the problem was spotted in #330