Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for bionic #95

Closed

Conversation

kubicgruenfeld
Copy link
Contributor

Pull Request (PR) description

adds support for ubuntu 18.04 - bionic

This Pull Request (PR) fixes the following issues

Fixes #75

@bastelfreak
Copy link
Member

Hi @kubicgruenfeld, thanks for the PR. Can you please add Ubuntu 18.04 to the metadata.json?

That will also automatically enable unit tests for this distribution.

Please also duplicate this block and adjust it for 18.04 to enable acceptance tests:

- rvm: 2.5.3
bundler_args: --without development release
env: PUPPET_INSTALL_TYPE=agent BEAKER_IS_PE=no BEAKER_PUPPET_COLLECTION=puppet5 BEAKER_debug=true BEAKER_setfile=ubuntu1604-64 BEAKER_HYPERVISOR=docker CHECK=beaker
services: docker
- rvm: 2.5.3
bundler_args: --without development release
env: PUPPET_INSTALL_TYPE=agent BEAKER_IS_PE=no BEAKER_PUPPET_COLLECTION=puppet6 BEAKER_debug=true BEAKER_setfile=ubuntu1604-64 BEAKER_HYPERVISOR=docker CHECK=beaker
services: docker
- rvm: 2.5.3
bundler_args: --without development release
env: PUPPET_INSTALL_TYPE=agent BEAKER_IS_PE=no BEAKER_PUPPET_COLLECTION=puppet6-nightly BEAKER_debug=true BEAKER_setfile=ubuntu1604-64 BEAKER_HYPERVISOR=docker CHECK=beaker
services: docker

Last but not least please add Ubuntu 18.04 here as well (this file is used to generate the .travis.yml from time to time.):

docker_sets:
- set: ubuntu1404-64
- set: ubuntu1604-64

@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Mar 10, 2019
@mcrauwel
Copy link
Member

mcrauwel commented May 16, 2019

This was fixed in #102

@mcrauwel mcrauwel closed this May 16, 2019
@kubicgruenfeld kubicgruenfeld deleted the proxysql-2.0-bionic branch May 18, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-work not ready to merge just yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 18.04 Bionic Beaver support
3 participants