add repo for 2.0.x #94
Conversation
kubicgruenfeld
force-pushed
the
proxysql-2.0
branch
2 times, most recently
from
ebe8dbf to
99a5a95
Compare
|
Hi @kubicgruenfeld, thanks for the PR! Can you have a look at the used email address in the commits? It isn't associated with your github account. |
bastelfreak
added
enhancement
|
i have added the other mailaddress to my github account. also the pr needs some more work. i wanted at first only add the repo for 2.0.x but decided afterwards it is more reasonable to also add support for galera hostgroups and ubuntu 18.04 here. or should i do this in seperate PRs? |
|
seperate PRs would be cool. That makes it way easier for us to review it. |
kubicgruenfeld
force-pushed
the
proxysql-2.0
branch
2 times, most recently
from
4375189 to
a930eb2
Compare
|
So i removed everything which is not related to the repo and will open other PRs for this. |
|
thanks @kubicgruenfeld. Can you take a look at the inline comment and also update the README.md for the paramter and an explanation? |
done. thanks for reviewing :) |
|
thanks! will merge it when travis gets green. |
| create_resources('apt::source', { 'proxysql_repo' => $proxysql::repo14}) | ||
| } | ||
| default: { | ||
| create_resources('apt::source', { 'proxysql_repo' => $proxysql::repo14}) |
There was a problem hiding this comment.
Why create_resources when Debian and splat operator for Redhat?
add repo for 2.0.x
Pull Request (PR) description
Adds support for the ProxySQL 2.0 repo.