Support to add resource via class parameters. Add manage_hostgroup_fo… #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Aug 31, 2018
bastelfreak
reviewed
Aug 31, 2018
bastelfreak
reviewed
Aug 31, 2018
manifests/init.pp
Outdated
| @@ -182,6 +207,7 @@ | |||
| -> class { '::proxysql::config':} | |||
| -> class { '::proxysql::service':} | |||
| -> class { '::proxysql::admin_credentials':} | |||
| -> class { '::proxysql::configure':} | |||
There was a problem hiding this comment.
please do not add the leading ::
bastelfreak
reviewed
Aug 31, 2018
|
Wow, what a massive amout of work, thanks for this! As in the other PRs, please check the used email address. |
MaxFedotov
force-pushed
the
resources
branch
from
fe7c242 to
08c8583
Compare
|
Email updated, review notes applied |
bastelfreak
reviewed
Sep 1, 2018
|
@MaxFedotov can you rebase on the current master? |
MaxFedotov
force-pushed
the
resources
branch
from
bb9d094 to
05fdad6
Compare
|
done |
|
let's continue with this now, of course on every PR we merge, another rebase will be required... |
MaxFedotov
force-pushed
the
resources
branch
from
05fdad6 to
95c9d1d
Compare
|
done |
mcrauwel
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to configure resources through class parameters using variables (
$mysql_servers,$mysql_users,$mysql_hostgroups,$mysql_rules,$schedulers)New param
manage_hostgroup_for_servers. This defines which provider will be called from mysql_servers. If true - default (proxy_mysql_server). If false - proxy_mysql_server_no_hostgroup, which don't look on hostgroup field of mysql_server. It is needed in order to allow configuration of this parameter by some external service - consul, script, etc. This can close #38