Move static defaults out of params.pp #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only OS specific defaults need to be in params.pp (or perhaps eventually in hiera data). By moving the static defaults to init.pp puppet-strings will be able to display the defaults. Later commits/PRs will improve data types and add puppet-strings tags.
bastelfreak
approved these changes
Sep 6, 2020
|
This replaces some of #127 and I think I've managed to prove that small PRs are better. https://github.com/voxpupuli/puppet-proxysql/compare/41d8b448c078c40eb11f118614a3e72a8bc97efa..543c81630de062c72e7235799e0a600ffdcb0f52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only OS specific defaults need to be in params.pp (or perhaps eventually
in hiera data). By moving the static defaults to init.pp puppet-strings
will be able to display the defaults.
Later commits/PRs will improve data types and add puppet-strings tags.