Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: explicitly stringify output of mysql query #142

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

LadyNamedLaura
Copy link
Contributor

Otherwise the result might corrupt the transactionstore.

For some reason some fields of the instance were still of the type Puppet::Util::Execution::ProcessOutput when puppet tries to serialize these into the transactionstore.yaml it adds the type.

When on a next run puppet tries to load the transactionstore.yam it thinks it's corrupted.

Transaction store file /opt/puppetlabs/puppet/cache/state/transactionstore.yaml is corrupt ((/opt/puppetlabs/puppet/cache/state/transactionstore.yaml): Tried to load unspecified class: Puppet::Util::Execution::ProcessOutput); replacing
Wrapped exception:
Tried to load unspecified class: Puppet::Util::Execution::ProcessOutput

Otherwise the result might corrupt the transactionstore.
@mcrauwel mcrauwel self-requested a review March 27, 2020 16:44
Copy link
Member

@mcrauwel mcrauwel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tests are green!

@mcrauwel mcrauwel merged commit 3f64c3d into voxpupuli:master Mar 27, 2020
@mcrauwel
Copy link
Member

Thanks Simon!

@alexjfisher alexjfisher added the bug Something isn't working label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants