Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reloading proxysql 2 as root #135

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Avoid reloading proxysql 2 as root #135

merged 1 commit into from
Mar 5, 2020

Conversation

alexjfisher
Copy link
Member

On EL6/7 the init.d script has a reload option. This should be used
instead of running /usr/bin/proxysql --reload as root.

This applies to EL6 with all versions of proxysql 2 and EL7 when using
proxysql >= 2 and < 2.0.7

Fixes #134

@alexjfisher
Avoid reloading proxysql 2 as root
5a3b805 
On EL6/7 the init.d script has a `reload` option.  This should be used
instead of running `/usr/bin/proxysql --reload` as root.

This applies to EL6 with all versions of proxysql 2 and EL7 when using
proxysql >= 2 and < 2.0.7

Fixes voxpupuli#134
@alexjfisher alexjfisher changed the title Avoid reloading proxysql 2 as root WIP: Avoid reloading proxysql 2 as root Mar 2, 2020
@alexjfisher alexjfisher changed the title WIP: Avoid reloading proxysql 2 as root Avoid reloading proxysql 2 as root Mar 5, 2020
ekohl
ekohl reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is reload used as a start command? In fact, why are status and stop overridden as well with what appears to be standard commands? Does the service really have no restart option or is that also outdated?

@alexjfisher
Copy link
Member Author

The actual restart command just does a stop and start.

@alexjfisher
Copy link
Member Author

and a normal start command doesn't use the --reload flag. It needs to if the user wants the config file to be re-read. By default, if it exists, proxysql will initialise itself from its own db it created when first run up.

@alexjfisher
Copy link
Member Author

More information on this here.

ekohl
ekohl approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very messy, but I guess this improves functionality so it's ok.

@alexjfisher alexjfisher merged commit eb22029 into voxpupuli:master Mar 5, 2020
cegeka-jenkins pushed a commit to cegeka/puppet-proxysql that referenced this pull request Aug 22, 2023
@alexjfisher
Merge pull request voxpupuli#135 from alexjfisher/issue_134
b6a9522 
Avoid reloading proxysql 2 as root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProxySQL 2 gets restarted as root
2 participants
@alexjfisher @ekohl