Don't install from github when manage_repo is false and remove unused repo parameter
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the general user expectation is that setting `manage_repo => false` will allow them to configure their own repo, or bind to a pulp or spacewalk channel etc somewhere in their profile class. With this change, `package_source` now defaults to `undef` for all Operating Systems. If the user sets a `package_source` that will always be used and no repo configured.
Due to a regression, it wasn't being used anyway. If a user wants to specify their own repo, they should set `manage_repo => false` and define the repository themselves in their profile/wrapper class.
alexjfisher
force-pushed
the
issue_78
branch
from
b5d1514 to
7b91a38
Compare
|
Updated to remove unused |
alexjfisher
changed the title
bastelfreak
approved these changes
Sep 23, 2019
alexjfisher
changed the title
manage_repo is false and remove unused repo parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the general user expectation is that setting
manage_repo => falsewill allow them to configure their own repo, or bind to a pulp orspacewalk channel etc somewhere in their profile class (or use the OS provided packages).
With this change,
package_sourcenow defaults toundeffor allOperating Systems. If the user sets a
package_sourcethat will alwaysbe used and no repo configured.