node_exporter 0.15.0 compatibiity #72
Conversation
manifests/node_exporter.pp
Outdated
| $service_name = 'node_exporter', | ||
| $user = $::prometheus::params::node_exporter_user, | ||
| $version = $::prometheus::params::node_exporter_version, | ||
| $arch = $::prometheus::params::arch, |
There was a problem hiding this comment.
please add datatypes to those parameters. An example can be found at https://github.com/voxpupuli/puppet-prometheus/pull/68/files
There was a problem hiding this comment.
hm isn't adding datatypes to all params a different aspect that should be adressed in a seperate PR?
well i did it anyway :)
manifests/node_exporter.pp
Outdated
| @@ -113,19 +124,28 @@ | |||
| validate_bool($manage_user) | |||
There was a problem hiding this comment.
please drop those validate_* calls. They are not needed if we have datatypes.
manifests/node_exporter.pp
Outdated
| @@ -113,19 +124,28 @@ | |||
| validate_bool($manage_user) | |||
| validate_bool($manage_service) | |||
| validate_bool($restart_on_change) | |||
| validate_array($collectors) | |||
| if $collectors != undef { | |||
There was a problem hiding this comment.
this is enough:
if $collectors { }
|
Thanks for this PR @TheMeier!
|
|
Hi @TheMeier, thanks for the updates. Can you check the used email address in your first commit and add it to your github profile? Otherwise the commti isn't associated with you (or change the email address in the commit). |
fixes #70 fixes #33 change collector parameterization to be compatible with node_exporter 0.15.0 this should be released with a major version since it breaks paramter compatinbility for two step migration of profiles and roles using this keep node_exporter::collectors paramter as noop with deprecation warning for at least one release
remove vallidate_*
|
email should be fine now |
|
Thanks! |
node_exporter 0.15.0 compatibiity
node_exporter 0.15.0 compatibiity
fixes #70
fixes #33
change collector parameterization to be compatible with node_exporter 0.15.0
this should be released with a major version since it breaks paramter compatinbility
for two step migration of profiles and roles using this keep node_exporter::collectors paramter as noop with deprecation warning for at least one release