Add support for mesos exporter #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 24, 2017
manifests/mesos_exporter.pp
Outdated
| $version = $::prometheus::params::mesos_exporter_version, | ||
| ) inherits prometheus::params { | ||
| $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}") | ||
| validate_bool($purge_config_dir) |
There was a problem hiding this comment.
Could you replace those validate function calls with native puppet datatypes?
|
@bastelfreak now using inbuilt puppet datatype |
|
Sorry, I was a bit unclear. Please add datatypes to all params. There are multiple classes in this module that you can use as an example. Please also check the used email address in your commit. It isn't associated with your github account/ |
Author: Tahaa Karim <[email protected]>
tahaalibra
force-pushed
the
mesos-exporter
branch
from
2af013c to
b8a6b12
Compare
|
@bastelfreak hi, yea i was thinking that maybe datatype should be added to other params. I added the params also a squashed the commit, i hope that will be fine |
|
Can you take a look at the failing acceptance test? |
|
yea sure |
|
I restarted the failing job. now tests are green. |
|
thanks @tuxmea |
juniorsysadmin
approved these changes
Nov 14, 2017
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Add support for mesos exporter
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Add support for mesos exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mesos exporter. Please review