have a $service_name parameter for all prometheus-exporters #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unki
changed the title
unki
force-pushed
the
add-service-name-parameter-to-all-exporters
branch
2 times, most recently
from
40e47f2 to
d0b562c
Compare
bastelfreak
reviewed
Feb 28, 2020
manifests/consul_exporter.pp
Outdated
| @@ -63,6 +65,7 @@ | |||
| String $log_level, | |||
| String $package_ensure, | |||
| String $package_name, | |||
| String $service_name, | |||
There was a problem hiding this comment.
for all $service_name parameters please use String[1] to prohibit empty empty strings
There was a problem hiding this comment.
Sure, will adapt the PR. Shall I change it for $package_name too?
As far as I remember I always have just copied the package-name-line as base and adapted it for the service. So there might be a mixture of String and String[1] there too.
unki
force-pushed
the
add-service-name-parameter-to-all-exporters
branch
2 times, most recently
from
c3becd8 to
303a043
Compare
|
@unki please have a look at the failing travis jobs |
unki
force-pushed
the
add-service-name-parameter-to-all-exporters
branch
from
303a043 to
14849dd
Compare
ready to go now |
|
thanks for the work! |
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
…-to-all-exporters have a $service_name parameter for all prometheus-exporters
|
looks like, not all exporters have this $service_name as daemon name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a mixture of exporters having a
$service_nameparameter or not.I've tried to make them all to look the same know.