Accept none as valid init_style
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarcat
requested changes
Nov 28, 2019
There was a problem hiding this comment.
i think this is a great idea. But there are bits missing.
- you should also cover the incantations of
init_styleinconfig.ppfor this to be complete all exporters need to have such a init_style parameter (postfix, for example, doesn't have one in Add postfix exporter #396 )that can be fixed by tweaking the init_style at theprometheusclass level, although I'm not sure I like that idea after all... but see Add postfix exporter #396 for a discussion on that.service_reloadfails here because there's no case fornonein the selector:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: No matching entry for selector parameter with value 'none' (file: /srv/puppet.torproject.org/stages/production/3rdparty/modules/prometheus/manifests/service_reload.pp, line: 9, column: 26) on node hetzner-nbg1-01.torproject.org
Merged
alexjfisher
changed the title
none as valid daemon init_stylenone as valid init_style
anarcat
approved these changes
Nov 28, 2019
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Accept `none` as valid `init_style`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more generic alternative to the
manage_systemd_unitpart of #303.install_methodalready acceptsnone, so I don't think it looks too wonky.