new feature - consul_exporter #36

pavloos · 2017-05-11T16:31:27Z

added consul_exporter

pavloos · 2017-06-02T07:41:18Z

bump

pavloos · 2017-08-16T10:03:41Z

Hello, Can this PR be looked into please ?

liamjbennett · 2017-09-11T14:43:50Z

This looks good to me. @bastelfreak any issues with me merging?

bastelfreak · 2017-09-24T12:30:50Z

manifests/consul_exporter.pp

+  }
+
+  $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
+  validate_bool($purge_config_dir)


Hi @pjfbashton, could you replace those legacy functions with native puppet datatypes?

bastelfreak · 2017-11-16T09:17:01Z

manifests/consul_exporter.pp

+#  [*web_telemetry_path*]
+#  Path under which to expose metrics. (default "/metrics")
+class prometheus::consul_exporter (
+  String           $arch                  = $::prometheus::params::arch,


datatypes \o/

bastelfreak · 2017-11-16T09:19:04Z

@pjfbashton thanks for the datatypes. Can you add at least a little unit test that verifies if the catalog compiles?

pavloos · 2017-11-16T09:55:51Z

@bastelfreak Oh, those tests failed a while ago, have changed anything ? I think there is a problem with prometheus service - it does not start (at least on Centos 7) on the first run with default settings (just include ::prometheus). Is this known bug?

I can try adding unit test although it is new to me, have you got an example I could take a look at?

bastelfreak · 2017-11-16T10:19:58Z

One example is at: https://github.com/voxpupuli/puppet-prometheus/blob/master/spec/classes/beanstalkd_exporter_spec.rb

I am not really sure why the acceptance tests fail randomly. I wasn't able to reproduce this locally. Sometimes they work, sometimes they don't :(

pavloos · 2017-11-16T11:08:28Z

Failed again on prometheus service not starting after first run. The same happens for me locally...

[root@e789cf77067a ~]# cat /etc/redhat-release 
CentOS Linux release 7.2.1511 (Core) 
[root@e789cf77067a ~]# puppet -V
4.10.5

puppet module install puppet-archive -v 2.1.0
puppet module install puppetlabs-stdlib -v 4.22.0
puppet module install camptocamp-systemd -v 1.1.0
git clone --branch v3.0.0 https://github.com/voxpupuli/puppet-prometheus.git \
  && mv puppet-prometheus/ /etc/puppetlabs/code/modules/prometheus
echo "include prometheus" > p.pp

[root@e789cf77067a ~]# puppet apply --verbose p.pp
Info: Loading facts
Info: Loading facts
Info: Loading facts
Warning: /etc/puppetlabs/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
   (in /etc/puppetlabs/puppet/hiera.yaml)
Notice: Compiled catalog for e789cf77067a.xps13.pjf in environment production in 0.45 seconds
Info: Applying configuration version '1510830353'
Notice: /Stage[main]/Prometheus::Install/Archive[/tmp/prometheus-1.5.2.tar.gz]/ensure: download archive from https://github.com/prometheus/prometheus/releases/download/v1.5.2/prometheus-1.5.2.linux-amd64.tar.gz to /tmp/prometheus-1.5.2.tar.gz and extracted in /opt with cleanup
Notice: /Stage[main]/Prometheus::Install/File[/opt/prometheus-1.5.2.linux-amd64/prometheus]/owner: owner changed 'pawel' to 'root'
Notice: /Stage[main]/Prometheus::Install/File[/opt/prometheus-1.5.2.linux-amd64/prometheus]/group: group changed 'pawel' to 'root'
Notice: /Stage[main]/Prometheus::Install/File[/opt/prometheus-1.5.2.linux-amd64/prometheus]/mode: mode changed '0755' to '0555'
Notice: /Stage[main]/Prometheus::Install/File[/usr/local/bin/prometheus]/ensure: created
Info: /Stage[main]/Prometheus::Install/File[/usr/local/bin/prometheus]: Scheduling refresh of Service[prometheus]
Notice: /Stage[main]/Prometheus::Install/Group[prometheus]/ensure: created
Notice: /Stage[main]/Prometheus::Install/User[prometheus]/ensure: created
Notice: /Stage[main]/Prometheus::Install/File[/var/lib/prometheus]/ensure: created
Notice: /Stage[main]/Prometheus::Install/File[/usr/local/share/prometheus]/ensure: created
Notice: /Stage[main]/Prometheus::Install/File[/usr/local/share/prometheus/consoles]/ensure: created
Info: /Stage[main]/Prometheus::Install/File[/usr/local/share/prometheus/consoles]: Scheduling refresh of Service[prometheus]
Notice: /Stage[main]/Prometheus::Install/File[/usr/local/share/prometheus/console_libraries]/ensure: created
Info: /Stage[main]/Prometheus::Install/File[/usr/local/share/prometheus/console_libraries]: Scheduling refresh of Service[prometheus]
Notice: /Stage[main]/Prometheus::Config/File[/etc/prometheus]/ensure: created
Info: /Stage[main]/Prometheus::Config/File[/etc/prometheus]: Scheduling refresh of Class[Prometheus::Run_service]
Notice: /Stage[main]/Prometheus::Config/File[prometheus.yaml]/ensure: defined content as '{md5}1463d85961bf7b73da62eaf7be1eaef9'
Info: /Stage[main]/Prometheus::Config/File[prometheus.yaml]: Scheduling refresh of Class[Prometheus::Service_reload]
Notice: /Stage[main]/Prometheus::Config/Systemd::Unit_file[prometheus.service]/File[/etc/systemd/system/prometheus.service]/ensure: defined content as '{md5}5ca91801aafbad71eec1c195d4d508dc'
Info: /Stage[main]/Prometheus::Config/Systemd::Unit_file[prometheus.service]/File[/etc/systemd/system/prometheus.service]: Scheduling refresh of Class[Systemd::Systemctl::Daemon_reload]
Info: Class[Systemd::Systemctl::Daemon_reload]: Scheduling refresh of Exec[systemctl-daemon-reload]
Notice: /Stage[main]/Systemd::Systemctl::Daemon_reload/Exec[systemctl-daemon-reload]: Triggered 'refresh' from 1 events
Info: Class[Prometheus::Run_service]: Scheduling refresh of Service[prometheus]
Notice: /Stage[main]/Prometheus::Run_service/Service[prometheus]/ensure: ensure changed 'stopped' to 'running'
Info: /Stage[main]/Prometheus::Run_service/Service[prometheus]: Unscheduling refresh on Service[prometheus]
Info: Class[Prometheus::Service_reload]: Scheduling refresh of Exec[prometheus-reload]
Notice: /Stage[main]/Prometheus::Service_reload/Exec[prometheus-reload]: Triggered 'refresh' from 1 events
Info: Creating state file /opt/puppetlabs/puppet/cache/state/state.yaml
Notice: Applied catalog in 19.75 seconds
[root@e789cf77067a ~]# systemctl status prometheus
● prometheus.service - Prometheus Monitoring framework
   Loaded: loaded (/etc/systemd/system/prometheus.service; enabled; vendor preset: disabled)
   Active: inactive (dead) since Thu 2017-11-16 11:06:13 UTC; 23s ago
  Process: 409 ExecReload=/bin/kill -HUP $MAINPID (code=exited, status=0/SUCCESS)
 Main PID: 369 (code=killed, signal=HUP)

Nov 16 11:06:13 e789cf77067a systemd[1]: Started Prometheus Monitoring framework.
Nov 16 11:06:13 e789cf77067a systemd[1]: Starting Prometheus Monitoring framework...
Nov 16 11:06:13 e789cf77067a systemd[1]: Reloaded Prometheus Monitoring framework.

pavloos · 2018-01-23T09:34:53Z

all green now @bastelfreak

tuxmea · 2018-01-23T12:16:33Z

looks good to me. thank you for the PR.

new feature - consul_exporter

Pawel Fiuto added 3 commits May 11, 2017 17:43

Adding consul_exporter

323a597

Cater for archives with different binary file location

e64379e

Linting file

8c6a0f4

Pawel Fiuto added 3 commits August 7, 2017 12:14

Merge remote-tracking branch 'upstream/master'

0a850ba

Drop support for custom_binary_location

359bc50

Support version 0.3.0 and higher

db5a999

bastelfreak reviewed Sep 24, 2017

View reviewed changes

Pawel Fiuto added 2 commits November 16, 2017 08:46

Merge remote-tracking branch 'upstream/master'

7a22112

Replaced legacy functions with native puppet datatypes

2fd641e

bastelfreak reviewed Nov 16, 2017

View reviewed changes

Pawel Fiuto added 2 commits November 16, 2017 11:39

Add unit test for consul_exporter

79ba509

Remove trailing comma

8313794

Pawel Fiuto added 2 commits November 16, 2017 12:59

Update README

a8b66dd

Merge remote-tracking branch 'upstream/master'

e5ce3de

tuxmea merged commit c1da72f into voxpupuli:master Jan 23, 2018

Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021

Merge pull request voxpupuli#36 from pjfbashton/master

67e055d

new feature - consul_exporter

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new feature - consul_exporter #36

new feature - consul_exporter #36

pavloos commented May 11, 2017

pavloos commented Jun 2, 2017

pavloos commented Aug 16, 2017

liamjbennett commented Sep 11, 2017

bastelfreak Sep 24, 2017

bastelfreak Nov 16, 2017

bastelfreak commented Nov 16, 2017

pavloos commented Nov 16, 2017 •

edited

Loading

bastelfreak commented Nov 16, 2017

pavloos commented Nov 16, 2017

pavloos commented Jan 23, 2018

tuxmea commented Jan 23, 2018

new feature - consul_exporter #36

new feature - consul_exporter #36

Conversation

pavloos commented May 11, 2017

pavloos commented Jun 2, 2017

pavloos commented Aug 16, 2017

liamjbennett commented Sep 11, 2017

bastelfreak Sep 24, 2017

Choose a reason for hiding this comment

bastelfreak Nov 16, 2017

Choose a reason for hiding this comment

bastelfreak commented Nov 16, 2017

pavloos commented Nov 16, 2017 • edited Loading

bastelfreak commented Nov 16, 2017

pavloos commented Nov 16, 2017

pavloos commented Jan 23, 2018

tuxmea commented Jan 23, 2018

pavloos commented Nov 16, 2017 •

edited

Loading