make config files readonly to daemons #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jul 11, 2019
| @@ -177,7 +177,7 @@ | |||
|
|
|||
| file { $config_dir: | |||
| ensure => 'directory', | |||
| owner => $user, | |||
| owner => 'root', | |||
There was a problem hiding this comment.
Wasn't there an issue on BSD and this needed to be 0 instead of root? I'm not 100% sure anymore.
There was a problem hiding this comment.
no, that was only the group that is wheel instead of root, and where you use gid=0. this is the owner, and root definitely exists on bsd.
|
Hi @anarcat, can you please rebase? |
|
On 2019-07-11 07:06:49, Tim Meusel wrote:
bastelfreak commented on this pull request.
> @@ -177,7 +177,7 @@
file { $config_dir:
ensure => 'directory',
- owner => $user,
+ owner => 'root',
Wasn't there an issue on BSD and this needed to be `0` instead of `root`? I'm not 100% sure anymore.
That's for the "root" group, which is called "wheel" in BSD, so we use
the numeric UID. I do not think it applies here.
|
|
Ping @anarcat |
It's bad practice to allow daemons to modify their own config files. This pattern seems to be common across this module, and I cannot think of a good reason why, as there is little chance (say) an exporter should have to modify its own config file. This reverts the policy by ensuring only minimal permissions are set on config files and directories deployed by Puppet. Only two directories are writable after this change: * /var/lib/prometheus * /usr/local/share/prometheus And I'm not even sure about the latter.
|
@bastelfreak pong, rebased. |
bastelfreak
added
enhancement
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
make config files readonly to daemons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
It's bad practice to allow daemons to modify their own config
files. This pattern seems to be common across this module, and I
cannot think of a good reason why, as there is little chance (say) an
exporter should have to modify its own config file.
This reverts the policy by ensuring only minimal permissions are set
on config files and directories deployed by Puppet. Only two
directories are writable after this change:
And I'm not even sure about the latter.
This Pull Request (PR) fixes the following issues
No issue was filed, but this problem was identified while working on the Debian packaging PR (#303) because the permissions on the files deployed by the Debian package would be broken.